crewAI icon indicating copy to clipboard operation
crewAI copied to clipboard

Enable telemetry opt-out #254

Open gardner opened this issue 1 year ago • 3 comments
trafficstars

Users can opt out of telemetry by setting the environment variable CREWAI_TELEMETRY_OPT_OUT

Fixes:

  • #254
  • #241
  • #372

This branch has been published to https://pypi.org/project/crewai-clean for testing.

gardner avatar Mar 30 '24 22:03 gardner

As an software architect within a bank which has tons of firewall, such requests for enabling firewall will never get approved , without opting out feature, we will get errors in logs, and we will have a sub standard experience. Unfortunately for us, it would be a no go with crewai if we don't have an opt out of telemetry.

raghav135 avatar Apr 02 '24 17:04 raghav135

+1 on disabling telemetry for running in airgapped environments, any updates on this?

ZQ-Dev8 avatar Apr 18 '24 18:04 ZQ-Dev8

@joaomdmoura Can you have a look at this one, please? Note in an enterprise environment this is a blocking point

arnaudgelas avatar May 17 '24 15:05 arnaudgelas

PR Review 🔍

⏱️ Estimated effort to review [1-5]

2, because the PR is small and the changes are straightforward, but it requires careful consideration of the environment variable handling and its impact on the telemetry system.

🧪 Relevant tests

No

⚡ Possible issues

Possible Bug: The environment variable check os.environ.get("CREWAI_TELEMETRY_OPT_OUT", False) will not work as intended because os.environ.get will return a string and not a boolean. This could lead to the telemetry not being disabled even if the environment variable is set.

🔒 Security concerns

No

Code feedback:
relevant filesrc/crewai/telemetry/telemetry.py
suggestion      

Consider explicitly checking for a specific string value to determine if telemetry should be disabled. This ensures that setting the environment variable to any string will not unintentionally disable telemetry. For example, you could check if the environment variable is set to 'true' or '1'. [important]

relevant lineif os.environ.get("CREWAI_TELEMETRY_OPT_OUT", False):

CodiumAI-Agent avatar May 28 '24 11:05 CodiumAI-Agent

We are really loving this framework but this feature is important. will this be making it to a release soon. Must have as most of the enterprises will have approve a tool without opt-out.

tsukhu avatar Jun 29 '24 06:06 tsukhu

This is a required option in order to gain enterprise adoption. For the future of crewAI I hope this gets approved by project owners.

elsewhat avatar Jul 23 '24 12:07 elsewhat

This PR is stale because it has been open for 45 days with no activity.

github-actions[bot] avatar Sep 06 '24 12:09 github-actions[bot]

I'm still keen to see this merged.

gardner avatar Sep 06 '24 19:09 gardner

Now implemented and docs updated :)

joaomdmoura avatar Sep 16 '24 12:09 joaomdmoura