cc-resource-archive icon indicating copy to clipboard operation
cc-resource-archive copied to clipboard

[Feature] Adding a trailing icon on filter text (topic name) and removing existing bracket and text

Open sj-jain opened this issue 2 years ago • 5 comments
trafficstars

Problem

Currently used bracket and text [X] as a trailing icon for removing filter choice is confusing seems like part of the text itself with no functionality .

Description

Adding a trailing icon according to vocabulary design language that improves the functionality and user experience for removing a tag or filter . This will also help upcoming fellow contributors to understand the functionality of the filters.

##Screenshots image 7 image 6 image 8 (3)

Implementation

Replace [x] to trailing cross icon svg from vocabulary docs

@possumbilities @TimidRobot

sj-jain avatar Mar 26 '23 14:03 sj-jain

Is this issue still open? I'm interested on solving this

tripathics avatar Mar 28 '23 18:03 tripathics

@tripathics glad to know that you're interested in solving this issue , its open but still it is not approved by maintainers hence not ready for work , for more info kindly look this https://opensource.creativecommons.org/contributing-code/repo-labels/

sj-jain avatar Mar 29 '23 11:03 sj-jain

@sj-jain agree I'm leaning both ways on the comma. It might be better to instead of adding the comma to increase the spacing between all the links a bit give them more visual room?

As for redoing the closing indicator the brackets are not perfect, but I'm not sure removing them makes it necessarily better.

Moving to a discussion so others can chime in on their thoughts.

possumbilities avatar Mar 31 '23 19:03 possumbilities

@possumbilities Is this issue relevant now, I would like to work on it

Murdock9803 avatar Jan 10 '24 09:01 Murdock9803

I agree with @sj-jain point regarding the design of the filters. Having the letter 'x' there might blend in too much with the text, especially for first-time visitors. Using an SVG for the 'x' icon would provide a clearer visual indication of its functionality. It would not only stand out more prominently but also enhance the overall user experience. Thanks for bringing this up!

Cappybara12 avatar Mar 03 '24 19:03 Cappybara12