snc
snc copied to clipboard
crc-org
Add machine config resource to create topolvm partition
Topolvm require a unused partition, which can be used by this operator and create layout accordingly. In this PR, machineconfig resource is used to create such partition as per document.
- https://docs.openshift.com/container-platform/4.15/installing/installing_with_agent_based_installer/installing-with-agent-based-installer.html#installing-ocp-agent-disk-partition_installing-with-agent-based-installer
- https://docs.openshift.com/container-platform/4.15/storage/persistent_storage/persistent_storage_local/persistent-storage-using-lvms.html
Thanks so much for looking into this and making it work, so the changes has to be done through MachineConfig and not directly using the ignition during boot for it to persist?
bundles are at https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/test-platform-results/pr-logs/pull/crc-org_snc/877/pull-ci-crc-org-snc-release-4.15-e2e-snc/1793504299356000256/artifacts/e2e-snc/gather-snc/artifacts/bundles.txt
this had questions around the (re)size of the root-partition, right?
yes, this was posted in the crc issue, https://github.com/crc-org/crc/issues/4117 i updated it with the information from the slack conversation
@anjannath Since we are going to move with 4.16 as default branch and same is what going to be tested. Should we close this PR and open a new against release-4.16 ?
have changed the base branch, but need to rebase the branch
For what it's worth, rebasing praveenkumar:disk_part does not trigger any conflicts if you use
git rebase HEAD~4 --onto origin/master
or
git rebase HEAD~4 --onto origin/release-4.16
@anjannath Since we are going to move with 4.16 as default branch and same is what going to be tested. Should we close this PR and open a new against release-4.16 ?
Don't we want this in master as well?
Another comment, while going over the commits in this PR, and reading this PR as well, I have no idea why we want it in crc. I understand it is enabling (or switch to?) topolvm, but there is no discussion/explanation why this is a good thing to do (shortcomings of the previous solution, advantages of topolvm, ...)
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please ask for approval from praveenkumar. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
![openshift-ci[bot] avatar](https://avatars.githubusercontent.com/in/91280?v=4 "Published by a pub.dev verified publisher"){kind=small}
Another comment, while going over the commits in this PR, and reading this PR as well, I have no idea why we want it in crc. I understand it is enabling (or switch to?) topolvm, but there is no discussion/explanation why this is a good thing to do (shortcomings of the previous solution, advantages of topolvm, ...)
there was some discussion about it in the issue: https://github.com/crc-org/snc/issues/854 but not a lot about its usefulness or shortcoming of the hostpath-provisioner.
the lvm-storage-operator supports a few more knobs for the pvc, like resize and setting size for the pvc which is not supported by hostpath-provisioner
@praveenkumar: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
| Test name | Commit | Details | Required | Rerun command |
|---|---|---|---|---|
| ci/prow/e2e-microshift | e8f727a16d062e85f812e9938f070a2b05b51f21 | link | true | /test e2e-microshift |
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.
Seems its not a good Return on investment, closing! sorry about the noise