snc icon indicating copy to clipboard operation
snc copied to clipboard

Add cifs-utils package to hyperV bundle

Open anjannath opened this issue 3 years ago • 6 comments
trafficstars

this package provides utilities for managing mounts of CIFS network file systems

its needed to make use of windows default CIFS/SMB feature for network file sharing between hosts

anjannath avatar Aug 10 '22 14:08 anjannath

I've downloaded the bundle from CI and can use it for testing, we should wait to merge this until we decide if we really want to use CIFS/SMB, see https://github.com/code-ready/crc/issues/3230#issuecomment-1211686987

/hold

anjannath avatar Aug 11 '22 09:08 anjannath

I am not convinced CIFS is currently the priority. I would say sshfs is more generic.

gbraad avatar Aug 19 '22 05:08 gbraad

/hold

Till we finalize we should go with cifs for windows file share work.

praveenkumar avatar Aug 19 '22 10:08 praveenkumar

I think we can go ahead with using CIFS/SMB for file sharing on windows, opened https://github.com/code-ready/crc/pull/3308

I am not convinced CIFS is currently the priority. I would say sshfs is more generic.

the reason to choose this over sshfs was mainly because of performance, while doing a very basic copy test using the SMB file sharing, it had good performance as mentioned in https://github.com/code-ready/crc/issues/3230#issuecomment-1211686987 also WSL and docker uses CIFS for their file sharing

although sshfs is generic and will also work on macOS and linux, we currently have working file sharing with virtiofs on these platforms which is more performant.

anjannath avatar Aug 22 '22 10:08 anjannath

WSL

WSL2 does not use CIFS from host to VM (for this they use 9p). They however use CIFS to mount VM to host using \\wsl\ (this however is a kernel based solution)

gbraad avatar Aug 23 '22 05:08 gbraad

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gbraad, praveenkumar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • ~~OWNERS~~ [gbraad,praveenkumar]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Aug 23 '22 05:08 openshift-ci[bot]

/unhold

praveenkumar avatar Sep 29 '22 10:09 praveenkumar

/cherry-pick master

praveenkumar avatar Sep 29 '22 10:09 praveenkumar

@praveenkumar: once the present PR merges, I will cherry-pick it on top of master in a new PR and assign it to you.

In response to this:

/cherry-pick master

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@praveenkumar: new pull request created: #583

In response to this:

/cherry-pick master

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.