crc icon indicating copy to clipboard operation
crc copied to clipboard

Add language to metrics

Open albfan opened this issue 6 months ago • 3 comments

fixes #4755

Summary by Sourcery

New Features:

  • Capture system language from LANG environment variable and include it in analytics traits on Linux

albfan avatar May 16 '25 08:05 albfan

Reviewer's Guide

This PR extends Linux analytics traits by capturing the system’s LANG environment variable and including it in the metrics payload.

File-Level Changes

Change Details Files
Include language setting in analytics traits on Linux
  • Retrieve LANG from the environment using os.Getenv
  • Chain a Set("lang", ...) call onto the existing traits builder
pkg/crc/segment/traits_linux.go

Assessment against linked issues

Issue Objective Addressed Explanation
#4755 Gather platform, OS, language, and country information for telemetry.
#4755 Identify crc usages. The PR only adds language information to the metrics and does not identify crc usages.

Possibly linked issues

  • #4755: PR adds language to telemetry metrics, addressing the issue's request for more info.

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an issue from a review comment by replying to it. You can also reply to a review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull request title to generate a title at any time. You can also comment @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in the pull request body to generate a PR summary at any time exactly where you want it. You can also comment @sourcery-ai summary on the pull request to (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the pull request to resolve all Sourcery comments. Useful if you've already addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull request to dismiss all existing Sourcery reviews. Especially useful if you want to start fresh with a new review - don't forget to comment @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

  • Contact our support team for questions or feedback.
  • Visit our documentation for detailed guides and information.
  • Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

sourcery-ai[bot] avatar May 16 '25 08:05 sourcery-ai[bot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign praveenkumar for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar May 16 '25 08:05 openshift-ci[bot]

This still miss mac and windows implementation

albfan avatar May 16 '25 08:05 albfan