remove enabling of file sharing and creation of smbshare from MSI

[anjannath]

fixes #4619

[praveenkumar]

@anjannath didn't we have this as part of preflight before and then moved it to MSI? if yes then we might to revert those commits instead of this?

[anjannath]

@anjannath didn't we have this as part of preflight before and then moved it to MSI? if yes then we might to revert those commits instead of this?

no, i also thought the same and i did check the logs before creating the PR, seems this was never added as preflight checks, i think because when we added this SMB sharing support we were already moving every privileged operation on windows already to MSI so when we added support for SMB directory sharing this was only added to the MSI..

$ git log --grep="smb" --grep="cifs" --oneline
fff474a33 msi: remove the smb share created during installation
2aa7059b4 msi: ignore errors from custom action creating the smb shared dir
4a52aef4e cifs: Add 'enable-shared-dirs' config for windows
b4cfc0ec5 add CIFS/SMB based file sharing for windows
2785de06d move initialization of SharedDirs to driver's CreatHost function

[openshift-ci[bot]]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign gbraad for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

[redbeam]

@anjannath I suggest closing this as I opened a separate PR that removes SMB file sharing support completely (#4879).

[anjannath]

closed in favor of #4879