crc icon indicating copy to clipboard operation
crc copied to clipboard

[wip] disable post-start functions that are done in snc

Open anjannath opened this issue 10 months ago • 3 comments
trafficstars

Description

This removes code doing the various post-start cluster provisioning tasks which are moved to the self sufficient bundle as part of PR https://github.com/crc-org/snc/pull/980

Relates to: https://github.com/crc-org/snc/issues/638

Type of change

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [x] Feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to change
  • [ ] Chore (non-breaking change which doesn't affect codebase; test, version modification, documentation, etc.)

Testing

  1. crc start should be successful when using the bundle from https://github.com/crc-org/snc/pull/980 (linux and windows bundle can be downloaded from the opensift CI artifacts https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/test-platform-results/pr-logs/pull/crc-org_snc/980/pull-ci-crc-org-snc-master-e2e-snc/1876969244206305280/)
  2. crc start should also succeed when using the current released bundle (4.17.0 or 4.17.10)

Contribution Checklist

  • [ ] Which platform have you tested the code changes on?
    • [x] Linux
    • [ ] Windows
    • [ ] MacOS

anjannath avatar Jan 09 '25 09:01 anjannath

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please ask for approval from anjannath. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Jan 09 '25 09:01 openshift-ci[bot]

/hold

praveenkumar avatar Jan 16 '25 14:01 praveenkumar

@anjannath: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/integration-crc a7dfae76023a5fa8116339cdaec4c5b62ba76eae link true /test integration-crc
ci/prow/images a7dfae76023a5fa8116339cdaec4c5b62ba76eae link true /test images
ci/prow/e2e-microshift-crc a7dfae76023a5fa8116339cdaec4c5b62ba76eae link true /test e2e-microshift-crc
ci/prow/e2e-crc a7dfae76023a5fa8116339cdaec4c5b62ba76eae link true /test e2e-crc
ci/prow/security a7dfae76023a5fa8116339cdaec4c5b62ba76eae link false /test security

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci[bot] avatar Jan 21 '25 08:01 openshift-ci[bot]