crc
crc copied to clipboard
crc-org
Update disk resize to work with `lvms-storage-operator`/topolvm
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please ask for approval from anjannath. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
![openshift-ci[bot] avatar](https://avatars.githubusercontent.com/in/91280?v=4 "Published by a pub.dev verified publisher"){kind=small}
this PR is not needed anymore, the snc PRs:
- https://github.com/crc-org/snc/pull/869
- https://github.com/crc-org/snc/pull/869 will take care of all the steps needed to install topolvm entirely on snc
this PR is not needed anymore, the snc PRs:
I assume this is no longer accurate as you updated the PR?
I'm a bit confused by ' update disk resize to work with new disk layout ', could you detail more in the commit log why we need to move the topolvm partition (ie what fails if we don't do this)? What is the order before, what is the order after? Could this be done proactively in snc? And can we resize both the root partition and the PVs without any issue?
i've updated the commit message.. but mentioning here as well: after adding a new partition at the end of disk, the partition layout is |efi|boot|root|topolvm|, now if we want to increase the size of the root partition we have to first move the topolvm partition to create the required free space after the root partition, earlier the root partition was the last partition on the disk and after increasing the disk size the additional free space was added after it, which is not the case anymore because the topolvm partition is there now
I'm a bit confused by ' update disk resize to work with new disk layout ', could you detail more in the commit log why we need to move the topolvm partition (ie what fails if we don't do this)? What is the order before, what is the order after? Could this be done proactively in snc? And can we resize both the root partition and the PVs without any issue?
i've updated the commit message.. but mentioning here as well: after adding a new partition at the end of disk, the partition layout is
|efi|boot|root|topolvm|, now if we want to increase the size of the root partition we have to first move thetopolvmpartition to create the required free space after therootpartition, earlier therootpartition was the last partition on the disk and after increasing the disk size the additional free space was added after it, which is not the case anymore because thetopolvmpartition is there now
Ah ok, we need to go from |efi|boot|root|topolvm|free space| to |efi|boot|root|free space|topolvm|. The topolvm partition is always the last one, but its end also has to be aligned with the end of the disk so that the freed space comes before rather than after it.
@anjannath: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
| Test name | Commit | Details | Required | Rerun command |
|---|---|---|---|---|
| ci/prow/security | d129b861633b41aadc73767b7b43959ccd0f94fb | link | false | /test security |
| ci/prow/e2e-crc | d129b861633b41aadc73767b7b43959ccd0f94fb | link | true | /test e2e-crc |
| ci/prow/integration-crc | d129b861633b41aadc73767b7b43959ccd0f94fb | link | true | /test integration-crc |
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.
seems this is not a good return on investment, closing it, sorry about the noise!
if users want to use topolvm they can manually enable/install it, we'll add a wiki entry with the steps