crc icon indicating copy to clipboard operation
crc copied to clipboard

Removal of podman preset from config and codebase

Open praveenkumar opened this issue 1 year ago • 9 comments

Podman preset was added when there was no podman machine and now it is not consumed by users and we also stopped updating the bundles from some time now. It would be better to remove it from crc codebase.

praveenkumar avatar Jan 22 '24 06:01 praveenkumar

We could first start by warning or erroring out when the podman preset is used, this is easier to revert if there are unexpected blockers with it (I hope not!)

cfergeau avatar Jan 22 '24 10:01 cfergeau

I agree with Christophe to first error out, but the next release after this would be OK to remove this.

Would it be OK for Gunjan (@vyasgun) to look at this?

gbraad avatar Jan 23 '24 06:01 gbraad

erroring out will be better, we already announced that the preset will be removed in 2.28.0 release https://github.com/crc-org/crc/releases/tag/v2.28.0

i think we should also stop shipping the podman client and putting it on ~/.crc/bin/oc/podman and adding to PATH?

anjannath avatar Jan 24 '24 06:01 anjannath

i think we should also stop shipping the podman client and putting it on ~/.crc/bin/oc/podman and adding to PATH?

podman client we ship for microshift/openshift bundle also to consume so that shouldn't be removed.

praveenkumar avatar Jan 24 '24 06:01 praveenkumar

Would it be OK for Gunjan (@vyasgun) to look at this?

Sure, assigned.

praveenkumar avatar Jan 24 '24 07:01 praveenkumar

i think we should also stop shipping the podman client and putting it on ~/.crc/bin/oc/podman and adding to PATH?

podman client we ship for microshift/openshift bundle also to consume so that shouldn't be removed.

Maybe we should integrate better with podman installed through podman's official installer, or even ship/use podman iwndows/mac installer instead of shipping our own binaries?

cfergeau avatar Jan 24 '24 09:01 cfergeau

^^^ I agree, but let's first at messaging and have a new issue to discuss how to integrate/distribute.

gbraad avatar Jan 24 '24 09:01 gbraad

^^^ I agree, but let's first at messaging and have a new issue to discuss how to integrate/distribute.

Yup, definitely a (long term) next step after we've dealt with the podman preset :)

cfergeau avatar Jan 24 '24 09:01 cfergeau

i think we should also stop shipping the podman client and putting it on ~/.crc/bin/oc/podman and adding to PATH?

The main issue i faced while using crc and podman machine together can be solved if we fix #4022

anjannath avatar Feb 07 '24 09:02 anjannath

#4062 has been merged, this can be closed.

cfergeau avatar Apr 24 '24 08:04 cfergeau