crc icon indicating copy to clipboard operation
crc copied to clipboard

[QE] Gating mechanism for PRs on downstream envs

Open adrianriobo opened this issue 3 years ago • 3 comments

We are testing the integration to allows running PRs on downstream environments.

This integration allows to run the full QE cycle on any PR and add a status check on the github PR with the results.

Due to downstream capacity, executions should be restricted. Current gating mechanism requires only approved PRs (created by Team members or eternals but approved by a Team member) can be run on the downstream.

In addition it would be necessary to add labeling to identify the value of running qe on a specific platform. As a proposal those labels could be:

  • Required-qe-macos
  • Required-qe-windows

adrianriobo avatar Jun 17 '22 08:06 adrianriobo

This is a much needed feature in CI! 🎉

  • Required-qe-macos
  • Required-qe-windows

labels looks good 👍🏽

Current gating mechanism requires only approved PRs (created by Team members or eternals but approved by a Team member) can be run on the downstream.

how do we approve PRs from external contributors, does approval mean the usual github PR approve after review?

anjannath avatar Jun 17 '22 09:06 anjannath

Yeah currently we are using that label of approve (same as after review), but if we want to keep the meaning of it and create a different one it will work the same

adrianriobo avatar Jun 17 '22 09:06 adrianriobo

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Sep 20 '22 21:09 stale[bot]