crc
crc copied to clipboard
introduce api versioning and move current apiset to v1
fixes #2543
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: To complete the pull request process, please ask for approval from anjannath after the PR has been reviewed.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
/hold
/unhold
@anjannath: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
| Test name | Commit | Details | Required | Rerun command |
|---|---|---|---|---|
| ci/prow/e2e-crc | 4eb051f1451088b2896e6a1c1efb950b82a555d0 | link | true | /test e2e-crc |
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.
how is this used? such as, what does the URL look like for a V2 api?
how is this used? such as, what does the URL look like for a V2 api?
the URL remains the same, we can provide the version using HTTP headers Version and Accept-Version
e.g:
$ curl -H 'Accept-version:v5' --unix-socket ~/.crc/crc-http.sock http://crc/api/config
Not Found
$ curl --unix-socket ~/.crc/crc-http.sock http://crc/api/config?cpus
{"Configs":{"cpus":4}}
$ curl -H 'Accept-version:v1' --unix-socket ~/.crc/crc-http.sock http://crc/api/config?cpus
{"Configs":{"cpus":4}}
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.