crc icon indicating copy to clipboard operation
crc copied to clipboard

Additional hosts added in hosts file should be clearly identified coming from crc

Open guillaumerose opened this issue 5 years ago • 8 comments

goodhost adds hosts to the hosts file but it is not clear in the file. We should have comments around our changes like:

127.0.0.1 localhost

# these entries were added by crc
x.x.x.x api.crc.testing
# end
``

guillaumerose avatar Nov 18 '20 11:11 guillaumerose

Would be very useful for crc cleanup

cfergeau avatar Nov 18 '20 12:11 cfergeau

This was handled in https://github.com/code-ready/crc/pull/1722 or is there something left?

anjannath avatar Dec 15 '20 07:12 anjannath

No, it still needs to be done.

guillaumerose avatar Dec 15 '20 08:12 guillaumerose

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Feb 13 '21 10:02 stale[bot]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Apr 30 '21 20:04 stale[bot]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Aug 22 '21 16:08 stale[bot]

This is still an issue.

cfergeau avatar Aug 23 '21 13:08 cfergeau

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Oct 22 '21 15:10 stale[bot]