crate-dbal
crate-dbal copied to clipboard
crate
[DRAFT] Add support for Doctrine 4
Summary of the changes / Why this is an improvement
Add PHPStan to help with moving from DBAL 2 to the current version. We can first fix up all the deprecations and move from there:
Issues:
The fetch Syntax is a bit different and some fetch modes are not supported anymore. FETCH_BOTH is not supported and I guess will not be supported. I don't know the usecase for this fetch mode maybe someone can enlighten me and tell me why it's needed? Maybe we don't even need it anymore. See here.
Checklist
- [ ] Link to issue this PR refers to (if applicable):
- [x] CLA is signed
Dear Julian,
apologies for the late reply. Your updates are much appreciated. Do you have any idea why CI fails on your patch?
With kind regards, Andreas.
/cc @surister, @kneth
Hey, I think we need a patch for the pdo driver as well. That's why it's failing.
It's still in a draft stage as well.
It can get quite frustrating to get to all the changes introduced in dbal 3 and 4. 5 is around the corner aswell. I will try to get back to it in the next few days, and will report back to this MR.
Sorry for the late reply. I probably have some time over Christmas to work on this.
My Plan is to get it running with DBAL 4.0, this way it can easily be upgraded to Frameworks already using 4.0. 5 will probably be another headache to get it to work and the Frameworks are not ready for it yet and I found no date for the planed release.
@JulianMar Thank you the update. Don't forget to enjoy the holiday season too 😄