typos
typos copied to clipboard
False positives in IPv6 addresses
I'm setting up typos as part of the diesel CI workflow. While doing that I noticed the following "false" positives:
- Detecting "typos" in IPv6 network addresses:
error: `ba` should be `by`, `be`
--> ./diesel_tests/tests/types.rs:1240:71
|
1240 | let value = ipnet::IpNet::V6(ipnet::Ipv6Net::from_str("2001:4f8:3:ba::/64").unwrap());
| ^^
|
- Detecting typos in strangely cased words:
error: `Ot` should be `To`, `Of`, `Or`, `Not`
--> ./dsl_auto_type/src/auto_type/case.rs:43:55
|
43 | `SHOUTY_SNAKE_CASE`, `dO_nOt_cHaNgE_cAsE`"
| ^^
|
For the second, there isn't really much we can do. Options for you include
- Making that a recognized identifier in your config
- Using the regex ignores to match patterns you have for this
- Use regex to create line ignores as a stopgap until we have other systems in place
For the first, I can see adding IPv6 detection. In the mean time, feel free to use any of the options mentioned for the second case.
In the future, please create issues for individual concerns. In this case, I'm just going to repurpose this for IPv6