Craig Francis

Results 76 comments of Craig Francis

When an `` is created at the moment, it will typically create a scrollbar (the thing I want to avoid). I assume the browser knows how big the "content" is...

@emilio, I'll be very happy if you can improve on this... my suggestion it just there to make the most basic implementation that should work for both browser and website...

Would something like [PR 132](https://github.com/WordPress/wpcs-docs/pull/132) work? I've simply taken the list of placeholders from the [wpdb::prepare documentation](https://developer.wordpress.org/reference/classes/wpdb/prepare/), which also notes the use of `%f`. I'm using list formatting, and trimmed/tweaked...

That's fair to emphasise the warning, have committed your suggestion.

Thanks for finding Vincent, I've created [PR #407](https://github.com/phpstan/phpstan-doctrine/pull/407), which simply allows int values for these arguments. There is no need to change the conditional return type, as it shouldn't return...

Thanks for checking Vincent. And yeah, it's annoying, but integers in PHP don't have the ability to add a literal flag onto them (not without major changes to the zval...

Audits panel would also work... in the same way that the "Accessibility Developer Tools" also uses it.

Yep, missing quotes is a common problem... a code base with many thousands of values being escaped, and all it takes is 1 mistake. The `mysqli_real_escape_string()` function is dangerous, developers...

That works. As to the website, yep, although it's more of a quick summary (so people are more likely to read): https://eiv.dev/ It does link to pages on my GitHub...

Are you asking to add more characters to the whitelist, so they don't get encoded? Maybe you could argue that certain characters like ":" don't need to be escaped, but...