react-native-sqlite-2 icon indicating copy to clipboard operation
react-native-sqlite-2 copied to clipboard

Fix framework target

Open eastcoastcoder opened this issue 7 years ago • 6 comments

Having issues building with the newest react-native-windows. For some reason having a target framework of "uap10.0" is invalid. I instead pointed it at 10586 and my build issues were solved. I think there was some breaking change happening either within react-native's ecosystem or UWP apps since the last sdk release.

eastcoastcoder avatar Feb 20 '18 14:02 eastcoastcoder

See a similar issue I had with RNFS https://github.com/itinance/react-native-fs/pull/447

eastcoastcoder avatar Feb 20 '18 14:02 eastcoastcoder

Cool! @hnq90 can you review it?

craftzdog avatar Feb 21 '18 00:02 craftzdog

@craftzdog @ethanx94 We can approve it after this issue https://github.com/Microsoft/react-native-windows/issues/1644 is resolved.

hnq90 avatar Feb 21 '18 01:02 hnq90

There's actually a better way to do this now. https://github.com/itinance/react-native-fs/pull/448/commits/7c5285ecc2b380ee6af7f8a72ee57ff0e73b8d14

eastcoastcoder avatar May 02 '18 02:05 eastcoastcoder

@ethanx94 Nice. Could you update your PR?

hnq90 avatar May 02 '18 02:05 hnq90

Well I tried to the same fix but ran into an issue resolving Microsoft.Data.SQLite I tried adding in 2.0.1 manually with the NuGet package manager but still no luck. Not sure what I'm missing here. I thought just hitting Restore NuGet packages by itself would do the trick. Might need a second opinion.

eastcoastcoder avatar May 02 '18 03:05 eastcoastcoder