dataDelimiter setting cannot be overridden by feedOptions

[jamesmacwhite]

trafficstars

Description

You cannot override the dataDelimiter setting on per feed basis with the feedOptions array, the default of -|- is always used.

Steps to reproduce

1. Set a different dataDelimiter value in feedOptions such as ,
2. Observe that the delimiter has not been changed

I believe its because the getConfig call doesn't pass the feedId at any point, in the DataHelper.php class

Additional info

• Plugin version: 4.2.0.1
• Craft version: 3.3.20.1

[jamesmacwhite]

On a similar note, I don't think all settings can be currently controlled via the feedOptions array, but the docs state:

Provide an array of any of the above options or Feed Settings to set specifically for certain feeds. Use the Feed ID as the key for the array.

https://docs.craftcms.com/feed-me/v4/get-started/configuration.html

This is slighly misleading because not all settings are I don't think currently.