carp.core-kotlin icon indicating copy to clipboard operation
carp.core-kotlin copied to clipboard

Published 20 hours ago • verified publisher icon cph-cachet

Add device registration to `ClientManager`.

Open Whathecode opened this issue 5 years ago • 1 comments

Currently, the ClientManager does not support registering devices. This needs to be done directly through the DeploymentService, thereby breaking encapsulation.

This causes an issue in which StudyRuntimeStatus retrieved through getStatus is not aware about remainingDevicesToRegister. For now, the status is only correct after having called tryDeployment.

Whathecode avatar Nov 09 '20 11:11 Whathecode

There was a bug related to this issue which has since been fixed in https://github.com/cph-cachet/carp.core-kotlin/commit/523ecc99eac9ffacd8485740aa0879da7dc2a202:

Furthermore, there is a bug in StudyRuntimeStatus.getStatus() in which a mutable list is passed (not copied) to an object which should be immutable.

Whathecode avatar Nov 10 '20 14:11 Whathecode