dbcsr icon indicating copy to clipboard operation
dbcsr copied to clipboard

Published 20 hours ago • verified publisher icon cp2k

Fix GCC8

Open fstein93 opened this issue 1 year ago • 3 comments

Follow up to #806

fstein93 avatar Jul 01 '24 10:07 fstein93

Can one of the admins verify this patch?

jenkins-cscs avatar Jul 01 '24 10:07 jenkins-cscs

FYI, there are macros to support version-checks; see https://github.com/cp2k/dbcsr/blob/develop/src/base/dbcsr_base_uses.f90#L45 (the comment gives an example for GCC and makes typical checks less intriguing ;-)

hfp avatar Jul 01 '24 11:07 hfp

LGTM. However, I wonder how this interferes with the pending decision to drop GCC8?

Given this change, GCC8 can be kept.

hfp avatar Jul 04 '24 07:07 hfp