Tatu Saloranta

Results 3020 comments of Tatu Saloranta

Quick note: required-ness works different for columnar formats, since there must always be at least some kind of placeholder to keep column indexes matching. Not sure if reported issue is...

Instead of submitting a huge PR with all changes without any discussion, we'd need multiple smaller PRs WITH discussion. I do not necessarily agree with all changes and definitely will...

Also was hoping find a case of 8. Use explicit asserts for exception instead of fails in a catch block. to see what this is. But due to size of...

@JooHyukKim I actually took parts and merged them separately. Couldn't cherry-pick commits, but changes applicable small enough it'd be ok. Will add a note next on things I applied.

@timo-a So, I think aside from 2 biggest noise factors ((1) and (3)), most changes make sense. So I applied following commits: * (2) Extracting `Employee` * (5) parts of...

Ok; most applicable changes merged, will close the PR. No need to modify 600+ classes for the rest.

@nedtwigg Apologies for somehow missing this report. I don't know if it'd be possible, but I'd really like a reproduction (I assume "entity" in report means "element") to fix the...

Ok, no. I do need a test case here to reproduce the problem. And I think the issue is with lookup, not bounds checks; some state is not being cleared,...

@nedtwigg understood. Thank you for all help you can give.

Quick note: I'd recommend trying this out with `2.18.0-rc1` since there have been many improvements to property introspection, specifically helping with record types. The issue may still be there but...