Tatu Saloranta comments

Results 3081 comments of


                                            Tatu Saloranta

Fix infinite loop due to integer overflow when reading large strings

Ok the basic idea is sound; even if we have no way to automate test runs. I'm ok with that. Couple of notes... First, I think this would be good...

Fix infinite loop due to integer overflow when reading large strings

Thank you @adamjshook ! I'll see if I can play with this PR wrt base class/method to use (or if shared method even makes sense).

Fix infinite loop due to integer overflow when reading large strings

Yes, this is probably a long-time bug; but due to its nature rare (unlikely to occur). But pretty nasty one if it ever happens. After fix, such case would probably...

Fix infinite loop due to integer overflow when reading large strings

I agree w/ @pjfanning that use of 2+ gig String values seems ill-advised. But just for sake of completeness, on size limits imposed: Jackson does not actually limit things to...

Fix infinite loop due to integer overflow when reading large strings

Closing this in favor of #1352.

Fix infinite loop due to integer overflow when reading large strings

Thank you for reporting this, suggesting the fix @adamjshook ! I merged #1352 so this will be fixed in: * 2.17.3 * 2.18.1

JsonSubTypes declared on multiple interfaces of a class results in order-dependent resolution and outcome

Yes, you are right in that order in which super-interfaces are reported matters currently. I'd be open to PR for more validation if anyone has one; and behavioral change on...

JsonSubTypes declared on multiple interfaces of a class results in order-dependent resolution and outcome

No problem. And thank you for including a reproduction; test case can make implementation little bit easier & ensure fix works.

JsonSubTypes declared on multiple interfaces of a class results in order-dependent resolution and outcome

@netomi What we see is flattening of annotations so that any annotation introspection only needs to be concerned with the highest priority annotation for given processed class. This is something...

JsonSubTypes declared on multiple interfaces of a class results in order-dependent resolution and outcome

@netomi Yes, I concur. On the other hand at least these are class-annotations (as opposed to field/method) so there'd be little bit less work -- but yes, some amount of...