coverlet icon indicating copy to clipboard operation
coverlet copied to clipboard

Upgrade Newtonsoft.Json to non-vulnerable version.

Open josteink opened this issue 3 years ago • 6 comments

More details here: https://github.com/advisories/GHSA-5crp-9r3c-p9vr

josteink avatar Jul 05 '22 08:07 josteink

/azp run

MarcoRossignoli avatar Jul 29 '22 13:07 MarcoRossignoli

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Jul 29 '22 13:07 azure-pipelines[bot]

Uhm. Build still red. Any action needed on my part?

josteink avatar Jul 30 '22 09:07 josteink

From the build:

/home/vsts/work/1/s/src/coverlet.console/ConsoleTables/ConsoleTable.cs(1,1): error IDE0073: A source file contains a header that does not match the required text [/home/vsts/work/1/s/src/coverlet.msbuild.tasks/coverlet.msbuild.tasks.csproj]

This is clearly not an error in my pull-request after all? :smile:

Edit: It clearly was.

josteink avatar Jul 30 '22 09:07 josteink

"Clearly not" ahem

Looking into the errors, and validating on git master, I could see the problem was exclusively present on my branch.

I've fixed 2 nullability-related issues (which was probably always there) in a couple of tests and it builds and tests cleanly on my machine now :smile:

josteink avatar Aug 01 '22 11:08 josteink

Build now succeeds, but 1 test now fails in CI (while not locally), and I don't have access to view what test failed or how it failed.

Help? :)

josteink avatar Aug 01 '22 11:08 josteink

/azp run

MarcoRossignoli avatar Jan 19 '23 18:01 MarcoRossignoli

PR is obsolete. The version of Newtonsoft.Json was updated with #1510

Bertk avatar Aug 24 '23 14:08 Bertk