cosmos-sdk icon indicating copy to clipboard operation
cosmos-sdk copied to clipboard

feat: implement autocli customization

Open aaronc opened this issue 3 years ago • 1 comments

Description

Ref #11775

This follows up on #11763 and implements the customization options specified there for query commands in client/v2/cli.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.

I have...

  • [ ] included the correct type prefix in the PR title
  • [ ] added ! to the type prefix if API or client breaking change
  • [ ] targeted the correct branch (see PR Targeting)
  • [ ] provided a link to the relevant issue or specification
  • [ ] followed the guidelines for building modules
  • [ ] included the necessary unit and integration tests
  • [ ] added a changelog entry to CHANGELOG.md
  • [ ] included comments for documenting Go code
  • [ ] updated the relevant documentation or specification
  • [ ] reviewed "Files changed" and left comments if necessary
  • [ ] confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.

I have...

  • [ ] confirmed the correct type prefix in the PR title
  • [ ] confirmed ! in the type prefix if API or client breaking change
  • [ ] confirmed all author checklist items have been addressed
  • [ ] reviewed state machine logic
  • [ ] reviewed API design and naming
  • [ ] reviewed documentation is accurate
  • [ ] reviewed tests and test coverage
  • [ ] manually tested (if applicable)

aaronc avatar Sep 12 '22 16:09 aaronc

Codecov Report

Merging #13251 (d9f3b6a) into main (81d033e) will increase coverage by 0.01%. The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #13251      +/-   ##
==========================================
+ Coverage   53.89%   53.90%   +0.01%     
==========================================
  Files         643      643              
  Lines       55464    55464              
==========================================
+ Hits        29891    29897       +6     
+ Misses      23173    23168       -5     
+ Partials     2400     2399       -1     
Impacted Files Coverage Δ
crypto/keys/internal/ecdsa/privkey.go 81.13% <0.00%> (-1.89%) :arrow_down:
x/group/keeper/keeper.go 56.64% <0.00%> (+0.39%) :arrow_up:
x/staking/simulation/operations.go 75.91% <0.00%> (+1.37%) :arrow_up:

codecov[bot] avatar Sep 12 '22 16:09 codecov[bot]

Anyone able to review this?

aaronc avatar Sep 27 '22 13:09 aaronc

Anyone able to review this?

I'm taking a look at this, sorry for the delay

amaury1093 avatar Oct 04 '22 15:10 amaury1093

Addressed all review comments. Okay to merge this?

aaronc avatar Oct 10 '22 20:10 aaronc

What to do about these gosec warnings? I fail to see how any of them are serious issues

aaronc avatar Oct 10 '22 21:10 aaronc

@tac0turtle I think I actually need your ACK here for some reason: image

aaronc avatar Oct 13 '22 20:10 aaronc

seems tests in the cli/v2 are failing

tac0turtle avatar Oct 13 '22 21:10 tac0turtle

seems tests in the cli/v2 are failing

It was a glitch. So strange

aaronc avatar Oct 13 '22 21:10 aaronc