cosmos-rust icon indicating copy to clipboard operation
cosmos-rust copied to clipboard

Published 20 hours ago • verified publisher icon cosmos

Type URLs for x/authz messages not present

Open AmitPr opened this issue 2 years ago • 4 comments

In cosmos-sdk-proto, I'm not seeing any Type URL implementations for any of the messages in the x/authz module. For example, MsgGrant, or GenericAuthorization.

AmitPr avatar Jun 06 '23 14:06 AmitPr

https://github.com/cosmos/cosmos-rust/blob/main/cosmos-sdk-proto/src/type_urls.rs This file maybe have not impl for the type.

DaviRain-Su avatar Jun 06 '23 16:06 DaviRain-Su

Yeah, right now adding the type URLs is a manual process unfortunately.

I opened an upstream PR which attempts to upstream some of the work from these crates so it can be automated with prost-build: https://github.com/tokio-rs/prost/pull/858

tony-iqlusion avatar Jun 06 '23 18:06 tony-iqlusion

Gotcha. Yeah it's not a super big deal even now as I can manually input the Type URLs when serializing to any. Just would be nice to have this all consistent!

AmitPr avatar Jun 06 '23 20:06 AmitPr

As a stopgap we could possibly add something to proto-build, otherwise PRs accepted if someone wants to add the type URLs by hand.

Edit: see #409 for discussion of using prost-build to auto-generate these.

tony-iqlusion avatar Jun 06 '23 22:06 tony-iqlusion