cosmos-proto icon indicating copy to clipboard operation
cosmos-proto copied to clipboard

feat: skip global registration for internal generated code

Open aaronc opened this issue 3 years ago • 2 comments

This PR causes proto files which are generated into internal go packages to not be registered with the global protobuf registries. This allows for packages to generate types which are not accessible or visible to any outside users so that they can precisely control the generation and versioning of these types without having to worry about third party consumers of these types.

In the short term this can help with removing the dependency in orm on api (which is problematic because of the complex api module versioning). It can also be used for other packages depending on api like client/v2 and maybe x/tx.

ref https://github.com/cosmos/cosmos-sdk/pull/11802

aaronc avatar Sep 08 '22 17:09 aaronc

There is a test failure here which I think is unrelated.

aaronc avatar May 21 '24 23:05 aaronc

makes sense! can we add a changelog?

This repo doesn't have a CHANGELOG 😉 . But I can add one

aaronc avatar Jun 25 '24 14:06 aaronc