cosmjs
cosmjs copied to clipboard
cosmos
fix: return tx response data without ignoring it
The DeliverTxRepsonse interface already has a data field so that it can contain tx result data. But, it doesn't get the data and set it into the DeliverTxResponse when querying tx results internally.
So, I fixed it to read data from tx results properly.
Hi @webmaster128 , It seems that CI jobs keep failing because of timeout from downloading docker images or initializing tendermint node. Since I don't have a permission to re-run jobs, I've pushed small commits to re-trigger CI jobs. But, it keeps failing. Different types of jobs fail each time. Could you re-run jobs or suggest any better way?
Sorry for keeping you wait so long. I just wanted to implement this change in a new PR but ran into this upcoming Cosmos SDK change, which opens up a larger API design question: https://github.com/cosmos/cosmjs/issues/1305#issuecomment-1291116184. Whoever finds this PR, feel free to follow #1305 for updates on this matter.
@webmaster128 We're looking to get the response from a Txn using cosmjs on our chain running SDK 45, does this PR being closed and unmerged mean there is no way to do so?
Looking at https://github.com/cosmos/cosmjs/issues/1305 it seems like I gave up on adding new features for 0.45 chains only. I guess the data is not available in the high level client.