chain-registry icon indicating copy to clipboard operation
chain-registry copied to clipboard

validation urgently needed

Open pyramation opened this issue 1 year ago • 2 comments

definition and schema files can be committed today without any validation, which causes many issues downstream.

We need to put the work on the devs submitting PRs, not on the maintainers to correct basic JSON Schema or JSON errors.

I have tooling that I can add that will fail and throw errors under these conditions, which we do want (IMO). I will propose a PR soon to take care of this. Documenting the issue here as it's a very general widespread issue. It's not necessarily specific to any particular issue (e.g. assetlist validation vs. versions schema definition validation).

pyramation avatar May 17 '24 21:05 pyramation

My suggestion:

  • I'll submit a PR with workflow that can run under workflow dispatch only — we manually clean up issues — then agree to turn on the automation with will cause any new PRs to fail with incorrect data.

pyramation avatar May 17 '24 21:05 pyramation

First Pass

  • [ ] schema definition validations (non-strict)
  • [ ] schema validations (non-strict)

Second Pass

This will require a bit more manual updates, but ideally we have strict validations

  • [ ] schema definition validations (strict)
  • [ ] schema validations (strict)

pyramation avatar May 17 '24 22:05 pyramation