Niels Bantilan

Results 469 comments of Niels Bantilan
trafficstars

just rebased, squashing commits that can go together

currently `strict` only operates on columns: https://github.com/unionai-oss/pandera/blob/main/pandera/backends/pandas/container.py#L480C9-L531 > I would suggest to modify strict=True to perform the following: when the schema does not contain any specification about the index, validate...

Hi @airibarne can you report what the failure is exactly?

The part of the code base responsible for converting pandera schema to json schema representation can be found here: https://github.com/unionai-oss/pandera/blob/cf6b5e45dfb0cd593f948b12a2a327bbf3699657/pandera/api/pandas/model.py#L574-L604 For simplicity it only converts pandera schemas to a very...

Currently don't have capacity to look into this issue, but contributions for this fix would be very welcome!

Sounds good! Were you thinking the errors object would be in the `DataFrame.pandera` accessor?

Thanks for the PR @brayan07! Looks like there are some lint and unit test errors. Be sure to [run tests](https://pandera.readthedocs.io/en/stable/CONTRIBUTING.html#run-tests) and [setup pre-commit](https://pandera.readthedocs.io/en/stable/CONTRIBUTING.html#set-up-pre-commit) in your dev env to make sure...

Hi @brayan07 sorry for the delayed review on this! I believe the test errors are coming from `from pydantic import GetCoreSchemaHandler`. Will need to move that import into the `PYDANTIC_V2`...

hey @nathanjmcdougall would you mind taking a look at some of the merge conflicts? Not sure what was added/reordered by isort

A contribution would have my blessing! 🙏 So the [`strict_filter_columns`](https://github.com/unionai-oss/pandera/blob/main/pandera/backends/pandas/container.py#L480-L531) parser uses the `ordered=True` kwarg to raise an error. Would just have to add the ordering functionality to that method....