react-slingshot
react-slingshot copied to clipboard
build script not failing the npm script
there are two issues with build.js
- after running the webpack config. the error condition check is incorrect. it should be
stats.hasErrors()
instead of
jsonStats.hasErrors
- if there are any issues with the build then the npm script doesnt exit with error code. maybe use process.exit(1)
Thanks! I'd welcome a PR on these.
ok cool!
possible to get access to push a branch? I have a fix for this
You should be able to push to your own fork and PR from that fork.
@atamaku1 Check out CONTRIBUTING.md Docs for instructions on adding your fix. Thanks! (Here's a link for ya) https://github.com/coryhouse/react-slingshot/blob/master/CONTRIBUTING.md