react-slingshot icon indicating copy to clipboard operation
react-slingshot copied to clipboard

build script not failing the npm script

Open atamaku1 opened this issue 8 years ago • 5 comments

there are two issues with build.js

  1. after running the webpack config. the error condition check is incorrect. it should be
stats.hasErrors()

instead of

jsonStats.hasErrors
  1. if there are any issues with the build then the npm script doesnt exit with error code. maybe use process.exit(1)

atamaku1 avatar Jul 17 '17 13:07 atamaku1

Thanks! I'd welcome a PR on these.

coryhouse avatar Jul 17 '17 13:07 coryhouse

ok cool!

atamaku1 avatar Jul 17 '17 13:07 atamaku1

possible to get access to push a branch? I have a fix for this

atamaku1 avatar Jul 20 '17 19:07 atamaku1

You should be able to push to your own fork and PR from that fork.

kwelch avatar Jul 20 '17 19:07 kwelch

@atamaku1 Check out CONTRIBUTING.md Docs for instructions on adding your fix. Thanks! (Here's a link for ya) https://github.com/coryhouse/react-slingshot/blob/master/CONTRIBUTING.md

DaneTheory avatar Aug 06 '17 14:08 DaneTheory