cortex-helm-chart
cortex-helm-chart copied to clipboard
Changing `http_listen_port` doesn't change `ServiceMonitor` podAnnotations values
We should update podAnnotations value if http_listen_port changes.
Original Comment:
Another concern I have -- and this is not entirely your fault because other deployments in this chart make the same mistake -- is that if http_listen_port is changed, this pod annotation will need to be changed to match.
https://github.com/cortexproject/cortex-helm-chart/blob/858b6e266951913c09659ef09c28932fa59fcb86/values.yaml#L73-L74
It would be easier for the user if this annotation was populated by the value. You could support references in values by using tpl near toYaml. Something like {{- tpl (toYaml .) $ | nindent 8 }}.
Not a blocker, since this is already inconsistent throughout the chart.
Originally posted by @kd7lxl in https://github.com/cortexproject/cortex-helm-chart/pull/407#discussion_r1003587300