py-etherscan-api icon indicating copy to clipboard operation
py-etherscan-api copied to clipboard

Feature Request: Add goerli testnet

Open corpetty opened this issue 6 years ago • 5 comments

Should be relatively self explanatory.

corpetty avatar Mar 14 '19 16:03 corpetty

Hey guys, I'd like to take this on if you don't mind. To implement it

  • add new file client.goerli.py

  • import from client.py, client class

  • override PREFIX with goerli endpoint

As im currently studying python can you confirm that this is the correct approach?

John-E5 avatar Mar 25 '19 11:03 John-E5

Looking at the Ropsten implementation now, I think this should be refactored to be a keyword argument in the default client, which overrides the PREFIX with the correct endpoint when specified.

I'm pretty sure that's all that is necessary.

Let me know what you attempt and I'll review changes.

corpetty avatar Mar 25 '19 12:03 corpetty

Ok thanks Corey, I should have something for you to review in the next few days

John-E5 avatar Mar 25 '19 13:03 John-E5

anything @John-E5 ?

corpetty avatar Apr 05 '19 15:04 corpetty

I have but I've been away most the week so nothing pushed yet, I'll be home tomorrow and I'll push for you to review @corpetty

John-E5 avatar Apr 06 '19 11:04 John-E5