cwa-app-ios icon indicating copy to clipboard operation
cwa-app-ios copied to clipboard

Implement all cells in code

Open dasdom opened this issue 5 years ago • 4 comments

Avoid duplicates

  • [x] This issue has not already been raised before
  • [x] If you are proposing a new feature, please do so in CWA-Wishlist

Current Implementation

CollectionViewCells and TableViewCells are implemented using Xibs.

Suggested Enhancement

CollectionViewCells and TableViewCells should be implemented in code

Expected Benefits

Code is easier to

  • refactor
  • document
  • reason about
  • automate
  • understand

In addition code is less likely to break with Xcode updates.


Internal Tracking ID: EXPOSUREAPP-1954

dasdom avatar Jun 21 '20 08:06 dasdom

Totally agree with you here. We are discussing this topic all the time within the team but we cannot convince some of the developers within the team. I'll keep this issue open until we convinced them. :neutral_face:

inf2381 avatar Jun 23 '20 15:06 inf2381

Could one of the devs give us an update about this issue which is soon almost a year old?

Or maybe @dasdom would like to take another look at the code and say if the situation has(n't) changed in the meantime?

Ein-Tim avatar May 17 '21 16:05 Ein-Tim

The project still uses simple Xibs for some cells. They seem to be simple and should be easy to replace with code.

Examples:

Screen Shot 2021-05-17 at 21 38 18 Screen Shot 2021-05-17 at 21 40 34

dasdom avatar May 17 '21 19:05 dasdom

Thanks. Updated internal ticket.

dsarkar avatar May 18 '21 08:05 dsarkar