coreos-assembler icon indicating copy to clipboard operation
coreos-assembler copied to clipboard

Generalize osmet-pack and use it for miniso packing

Open jlebon opened this issue 3 years ago • 2 comments

The first commits work towards generalizing osmet-pack to support just running the matched coreos-installer in a supermin VM. The final patch makes the miniso packing step use it. Its commit message follows.


cmd-buildextend-live: pack miniso with composed coreos-installer

Currently, we're packing the miniso using the coreos-installer from the cosa image. This is not ideal however, because it introduces skew between the packing side and the unpacking side, which may be older.

Fix this by using the new runvm-coreos-installer to pack with the composed coreos-installer.

For more information, see: https://github.com/coreos/coreos-assembler/pull/3009

jlebon avatar Jul 26 '22 21:07 jlebon

Looks like osmet packing is unhappy in CI.

bgilbert avatar Jul 27 '22 05:07 bgilbert

OK I'm just discovering that we need this in order to use newer coreos-installer to build older RHCOS, e.g 4.10.

I'm worried this is actually a symptom of a bigger picture problem in that the rhcos-4.11 style branches are basically a lie because the Fedora repos keep floating forward.

I think I'd say we actually pin the versions of key tools used in this repository as a general rule - and that includes e.g. rpm-ostree where I think we also may have removed or changed experimental/hidden features that are depended on by older coreos-assembler branches. And we haven't noticed because we haven't been rebuilding containers for older branches often.

EDIT: Sorry I see https://github.com/coreos/coreos-assembler/commit/ca2dbcca1d0b10c8fdb6e54cdc46903865920573

cgwalters avatar Sep 23 '22 15:09 cgwalters

OK, I think this is finally ready to go now!

jlebon avatar Oct 14 '22 20:10 jlebon

/retest

jlebon avatar Oct 17 '22 13:10 jlebon

Prow failing on https://github.com/openshift/os/issues/1028. /override ci/prow/rhcos

Let's merge this once FCOS releases are done this week.

jlebon avatar Oct 17 '22 14:10 jlebon

@jlebon: Overrode contexts on behalf of jlebon: ci/prow/rhcos

In response to this:

Prow failing on https://github.com/openshift/os/issues/1028. /override ci/prow/rhcos

Let's merge this once FCOS releases are done this week.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci[bot] avatar Oct 17 '22 14:10 openshift-ci[bot]