helm icon indicating copy to clipboard operation
helm copied to clipboard

Allow to skip ConfigMap creation

Open cep21 opened this issue 1 year ago • 1 comments

Why is this pull request needed and what does it do?

A requested rebase and merge from PR #41

Which issues (if any) are related?

Checklist:

  • [x] I have bumped the chart version according to versioning.
  • [x] I have updated the chart changelog with all the changes that come with this pull request according to changelog.
  • [x] Any new values are backwards compatible and/or have sensible default.
  • [x] I have signed off all my commits as required by DCO.

Changes are automatically published when merged to main. They are not published on branches.

Note on DCO

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

cep21 avatar May 19 '24 18:05 cep21

Hi @hagaibarel , this is the rebased PR

cep21 avatar May 19 '24 19:05 cep21

@cep21 I think the last commit wasn't properly signed-off, please fix

hagaibarel avatar May 29 '24 07:05 hagaibarel

@cep21 I think the last commit wasn't properly signed-off, please fix

Fixed!

cep21 avatar May 29 '24 20:05 cep21

@cep21 great job, thanks for working on this

hagaibarel avatar May 30 '24 07:05 hagaibarel