cordova-plugin-iosrtc icon indicating copy to clipboard operation
cordova-plugin-iosrtc copied to clipboard

fix getProjectName() when config.xml:name has an attribute

Open dcrousset opened this issue 3 years ago • 4 comments

dcrousset avatar Jul 20 '22 19:07 dcrousset

Hello @dcrousset thank you for your contribution. I have to double check because in the past I think this regexp was like that but then was changed because it caused issue. Unless I find old issue about it I will merge.

hthetiot avatar Jul 20 '22 20:07 hthetiot

I will check for #597 regression before merging.

hthetiot avatar Jul 20 '22 20:07 hthetiot

Hey @hthetiot

#597 seems to be another problem. In our situation, we have an argument within our name tag, like this :

<name short="short">long name</name>

Thanks.

dcrousset avatar Jul 20 '22 21:07 dcrousset

Thank you for replying with use case, I'm always cautious with RegExp for xml parsing, specially with ".*", I need a bit more time to validate some other issue we had with that line and if it too risky will use a DomParser instead.

Thank you for your understanding.

hthetiot avatar Jul 21 '22 07:07 hthetiot