talk icon indicating copy to clipboard operation
talk copied to clipboard

[CORL-2598]: only traverse after loading more comments if Z key clicked button

Open kabeaty opened this issue 3 years ago • 1 comments
trafficstars

What does this PR do?

This addresses an issue where the keyboard shortcuts was overzealously traversing to the next unseen comment after a load more button is clicked (Show more replies, Load more or View new comments). It was traversing even when the button was just clicked, and we want it to only traverse if the button is clicked by the Z key.

What changes to the GraphQL/Database Schema does this PR introduce?

none

Does this PR introduce any new environment variables or feature flags?

no

If any indexes were added, were they added to INDEXES.md?

How do I test this PR?

Use Z key to interact with the stream. Set traversal focus to a comment. On another tab, create two new replies on different root comments via subscription below that comment with traversal focus. On the first tab, where the new Show more replies buttons showed up, click the second/bottom button. See that it reveals the new reply but does NOT affect traversal focus. However, if you then use the Z key, it should still click the topmost Show more replies button and reveal its new reply and set traversal focus to that reply.

How do we deploy this PR?

kabeaty avatar Jul 07 '22 17:07 kabeaty

Deploy Preview for gallant-galileo-14878c canceled.

Name Link
Latest commit 1448766c85b2d87d5a54b1b12325085fb41ff073
Latest deploy log https://app.netlify.com/sites/gallant-galileo-14878c/deploys/62c71ece33b16800086b832d

netlify[bot] avatar Jul 07 '22 17:07 netlify[bot]

Closing, as these changes were included in https://github.com/coralproject/talk/pull/4010

kabeaty avatar Aug 26 '22 12:08 kabeaty