coq-dpdgraph icon indicating copy to clipboard operation
coq-dpdgraph copied to clipboard

avoid warnings emitted by Coq

Open ybertot opened this issue 5 years ago • 8 comments

Only modifications in the Coq source files.

ybertot avatar Sep 24 '20 10:09 ybertot

Sorry to be late, but now, it seems that there are still some warnings, and moreover, it fails on:

Error: Unbound module Names.GlobRef.Ordered_env

A version problem?

Karmaki avatar Oct 29 '20 07:10 Karmaki

After git rebase, it seems the error has disappeared.

ybertot avatar Oct 29 '20 12:10 ybertot

Only the test-suite fails, and it seems this is only due to re-ordering in the graph.

ybertot avatar Oct 30 '20 09:10 ybertot

What about merging your other PR into this one and updating the oracles? Sorry, but I prefer not to merge a branch where the tests fail...

Karmaki avatar Oct 30 '20 09:10 Karmaki

I agree on the point concerning not merging a branch where tests fails.

ybertot avatar Oct 30 '20 09:10 ybertot

Some of the changes cannot be fixed by sorting results. It seems there was a symbol for the section variable A that was removed and it shifts the indices of all nodes (this is for the graph.dpd file).

ybertot avatar Oct 30 '20 11:10 ybertot

OK, but if it looks "normal" (I mean, due to coq internal modifications), you can just copy the new results in the oracles, and it will be ok then.

Karmaki avatar Oct 30 '20 11:10 Karmaki

I agree, I am checking the normalcy of the graph just now.

ybertot avatar Oct 30 '20 11:10 ybertot