qup icon indicating copy to clipboard operation
qup copied to clipboard

Fix for Redis spawning new clients for each topic/queue

Open sardaukar opened this issue 10 years ago • 7 comments
trafficstars

this also includes a RSpec syntax update, I can't stand deprecation warnings :)

OK, so this fixes https://github.com/copiousfreetime/qup/issues/20, but the behavior is not covered in tests. I'm not too well-versed in TDD, and would appreciate guidance in getting it done.

Thanks for the push to do this myself, the code is really clean and the change was real quick!

sardaukar avatar Feb 16 '15 23:02 sardaukar

btw, couldn't get Kestrel to run locally, so didn't touch those tests

sardaukar avatar Feb 16 '15 23:02 sardaukar

Hmm, not sure why the build failed - it passes locally for me on 2.1.5, with Redis 2.8.19

sardaukar avatar Feb 16 '15 23:02 sardaukar

Oh, I see - I wasn't using Bundler, so I have newer versions of RSpec and such... do you want to update the dependencies?

sardaukar avatar Feb 16 '15 23:02 sardaukar

I'm doing some dependency updates right now to accomodate your pull request, Looks good so far.

copiousfreetime avatar Feb 18 '15 02:02 copiousfreetime

You can ignore the travis-ci items, that's because the maildir gem now says it requires ruby 2.0 or higher and jruby has 1.8 and 1.9 modes. I've merged this pull request with #22 (basically lots of project maintenance cleanup). Check out the redis-refactor branch and make sure it satisfies your needs. If so I'll close this one and merge in #22 and push a new gem.

copiousfreetime avatar Feb 18 '15 04:02 copiousfreetime

Oh, and add yourself to CONTRIBUTING.md. A commit on this pull request will do, I'll cherrypick it over.

copiousfreetime avatar Feb 18 '15 04:02 copiousfreetime

@sardaukar just making sure the redis-refactor branch works for you, I'm going to close this today and push a new qup release.

copiousfreetime avatar Mar 12 '15 15:03 copiousfreetime