Evan Zhou

Results 85 comments of Evan Zhou
trafficstars

Can you be more specific about the `hot key` issue?

When this project was created, the Go GC didn't omit map value.

You can just copy and paste the code in base to create custom dialects.

Well, I took a look at it again, it doesn't work. I made those structs and functions private to avoid breaking the API when I refactor the code. I think...

Can you write a test for this issue. Thank you. And have you tested that this change is compatiable with old data?

I mean the data created before this change, before this change, tables was created with 'TEXT" column type for `time.Time` go type. And can you explain why this change fixes...

OK, now I know why this change fixes that issue. Please add a test cover this issue, then I will merge it. Thank you.

It is a nice feature to have. Can you implement it, write a couple of test cases and send me a pull request? Thank you.

You can set a single byte value like []byte{0} instead of empty []byte{}.