commitlint icon indicating copy to clipboard operation
commitlint copied to clipboard

feat: update conventional-changelog packages

Open escapedcat opened this issue 1 year ago • 2 comments

Update packages:

  • conventional-changelog-angular to v8
  • conventional-changelog-atom to v5
  • conventional-changelog-conventionalcommits to v8
  • conventional-commits-parser to v6

@JounQin I gave it a try and failed. If you find some time maybe you can have a look?

escapedcat avatar May 07 '24 16:05 escapedcat

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

codesandbox-ci[bot] avatar May 07 '24 17:05 codesandbox-ci[bot]

From what I've observed on https://github.com/insurgent-lab/commitlint-config/pull/99, upgrading conventional-changelog-conventionalcommits to v8 in config-conventional breaks the ! in commit titles:

validMessages: [
  'fix: some message',
  'refactor!: some message', // <- fails
  'fix(scope): some message',
  'fix(scope): some Message',
  'fix(scope): some message\n\nBREAKING CHANGE: it will be significant!',
  'fix(scope): some message\n\nbody',
  'fix(scope)!: some message\n\nbody', // <- fails
],

CI test run: https://github.com/insurgent-lab/commitlint-config/actions/runs/9463301740/job/26068172529

Example failure from @commitlint/cli:

â§—   input: refactor!: migrate to ESM

BREAKING CHANGE: the package is now pure ESM
✖   subject may not be empty [subject-empty]
✖   type may not be empty [type-empty]

✖   found 2 problems, 0 warnings

I'll stay on 7.0.2 for now, no big deal, I just wanted to add some potentially useful input here, especially since the failure in CI here isn't very helpful

sheerlox avatar Jun 11 '24 10:06 sheerlox

Just a heads up, that I have been working on this for the past few days and hope to have a PR in the next day or two. There is somewhat of tangle of version dependencies, so the PR is going to be addressing/fixing multiple issues that are currently marked as blocked in the repo. Currently I have a version that passes yarn build, yarn test, yarn deps, and yarn pkg in my dev setup, but I think I can clean up a few places in the code before submitting it, which is what I am working on today.

YasharF avatar Sep 30 '25 19:09 YasharF

@YasharF wow, great to hear! I'm sure it's a lot to tackle. Thanks for trying!

escapedcat avatar Oct 01 '25 08:10 escapedcat