contour icon indicating copy to clipboard operation
contour copied to clipboard

Truncated % symbols

Open cqexbesd opened this issue 2 years ago • 6 comments
trafficstars

Contour Terminal version

0.4.0-master-616315cc

Installer source

Github: source code cloned

Operating System

Arch Linux as of approx a week ago

Architecture

x86-64

Other Software

No response

Steps to reproduce

Type %

Expected Behavior

No response

Actual Behavior

image

The truncation occurs when using the SF Mono or LiberationMono font.

Additional notes

No response

cqexbesd avatar Oct 12 '23 21:10 cqexbesd

@Yaraslaut didn't we recently work on texture atlas wrt vertical bar? that smells related.

christianparpart avatar Oct 12 '23 22:10 christianparpart

we did, https://github.com/contour-terminal/contour/issues/1022 issue was LCD rendering, this looks more like font fallback fault for me

Yaraslaut avatar Oct 13 '23 03:10 Yaraslaut

I can not reproduce it, so it seems this is font fallback. This is LiberationMono image

Yaraslaut avatar Oct 13 '23 04:10 Yaraslaut

IIRC @cqexbesd is running a really small font size at only 96dpi. This is also why is underline at small font sizes looks so creepy. I can look at it once feeling less sick and back in the office, so I can investigate with him together at his desk :)

christianparpart avatar Oct 13 '23 06:10 christianparpart

I can not reproduce it, so it seems this is font fallback. This is LiberationMono

I think this requires a small enough font to be reproducible.

christianparpart avatar Oct 22 '23 21:10 christianparpart

I tried to reproduce this with small font (down to 5 pt) and still can not reproduce this behavior, @cqexbesd if you still have this bug, output of contour debug "font.render,vt.rasterizer,font.textshaping" can give us some hints

Yaraslaut avatar May 07 '24 09:05 Yaraslaut

I just updated to the latest master and I can't reproduce it anymore either so I think it has been fixed. Thanks!

cqexbesd avatar May 13 '24 09:05 cqexbesd