contour icon indicating copy to clipboard operation
contour copied to clipboard

Insert of second image corrupts sixel graphics

Open Yaraslaut opened this issue 2 years ago • 7 comments
trafficstars

Contour Terminal version

Contour Terminal Emulator 0.3.11-master-cd0aa937

Installer source

Github: source code cloned

Operating System

RHEL

Architecture

x86-64

Other Software

julia

Steps to reproduce

https://user-images.githubusercontent.com/44506630/221343690-788f3798-f458-4d73-8e12-e5bebfc2bc9a.mp4

Expected Behavior

No response

Actual Behavior

sixel rendering is broken

Additional notes

To reproduce this behavior size of the terminal in pixels must exceed 1080p

figure lines

Yaraslaut avatar Feb 23 '23 09:02 Yaraslaut

I am looking at this from my phone, sorry for this. Is the problem that at the end of the scroll, the background image is shining through?

christianparpart avatar Feb 26 '23 21:02 christianparpart

I wonder if this is only happening on qml branch or also on master. 🤔

christianparpart avatar Feb 26 '23 21:02 christianparpart

I wonder if this is only happening on qml branch or also on master. thinking

No, I am seeing same behaviour on current master as well Contour Terminal Emulator 0.3.11-master-99d6e65a

Yaraslaut avatar Feb 27 '23 06:02 Yaraslaut

Ok thx. This was just a hunch.

christianparpart avatar Feb 27 '23 06:02 christianparpart

I am looking at this from my phone, sorry for this. Is the problem that at the end of the scroll, the background image is shining through?

The problem is that after i insert second image first becomes corrupted and i see this: image

Yaraslaut avatar Feb 27 '23 06:02 Yaraslaut

Can be reproduced with one image, example julia code f = Figure(resolution=(2000,1100)); ax = Axis(f[1,1]); lines!(ax,rand(100)); f

Yaraslaut avatar Oct 03 '23 17:10 Yaraslaut

We figured out that #1458 is only a interim workaround but not an ultimate fix.

What should be done to close this ticket is to probably have a atlas texture size with the dimension of the current screen this window is living in.

  • if the window is moved to another screen (or the physical screen size is changed), then the texture atlas needs to be re-allocated
  • if the font size is changed only, then the texture atlas itself only needs to be re-addressed and re-initialized but not re-created.

christianparpart avatar Feb 06 '24 20:02 christianparpart