continue icon indicating copy to clipboard operation
continue copied to clipboard

feat(#898): add Jira api v2 support

Open theBenForce opened this issue 1 year ago • 6 comments

Closes #898

theBenForce avatar Mar 01 '24 21:03 theBenForce

Deploy Preview for continuedev canceled.

Name Link
Latest commit cc9b96038bb0b88156729d1c39e6eec1794fe76a
Latest deploy log https://app.netlify.com/sites/continuedev/deploys/65e24a74f9690f0008aad029

netlify[bot] avatar Mar 01 '24 21:03 netlify[bot]

@theBenForce This is great work! We prefer to take all PRs through the preview branch so that they have a chance to be tested in the pre-release extension before going fully live. Would you be able to make this PR against the preview branch instead? This is also important because I made a small handful of changes to your original PR (mostly with regards to the importing of the adf-to-md library

sestinj avatar Mar 02 '24 04:03 sestinj

@theBenForce Thank you! Assuming it's mostly ready, would you like me to handle the few merge conflicts? Happy to do so

sestinj avatar Mar 02 '24 18:03 sestinj

I haven't had a chance to test it yet, I wanted to make sure I didn't break anything before it got merged.

theBenForce avatar Mar 03 '24 02:03 theBenForce

I just verified that my updates work with both the v2 and v3 API.

theBenForce avatar Mar 04 '24 20:03 theBenForce

Should be ready for review @sestinj, I've verified it works with v2 and v3 APIs. Let me know if I need to update anything else.

theBenForce avatar Mar 04 '24 20:03 theBenForce

@theBenForce accidentally merged before asking this, but is there anything else that needs to be added to the documentation? Using my same config from before gives a 404

sestinj avatar Mar 07 '24 21:03 sestinj

@sestinj you'll have to set apiVersion to "2" since you're not on API v3.

theBenForce avatar Mar 09 '24 16:03 theBenForce