continue icon indicating copy to clipboard operation
continue copied to clipboard

Confirm deletion of models in dialog

Open simonbukin opened this issue 1 year ago • 1 comments

Validations

  • [X] I believe this is a way to improve. I'll try to join the Continue Discord for questions
  • [X] I'm not able to find an open issue that requests the same enhancement

Problem

Currently, deleting a model from the Continue sidebar is as simple as clicking the delete icon in the selection dialog. I accidentally deleted a model this way, as the trash can icon shows up on hover and isn't persist.

Screenshot 2024-02-07 at 2 37 27 PM

Solution

I think there is a simple solution here, and another that has a better user experience.

  • Option 1 -> Show trash can icon persistently, instead of on hover. This is a quick fix, and would solve the accidental click problem if a user isn't expecting something to show up on hover.
  • Option 2 -> Show a confirm dialog on deletion. I think this would be a cleaner user experience, as this is a destructive action and should be confirmed before being executed.

I'd be happy to contribute these changes, but just wanted to check if my initial thoughts here were warranted.

simonbukin avatar Feb 07 '24 22:02 simonbukin

confirmation dialog 👍 .

pjv avatar Feb 08 '24 19:02 pjv

@pjv @simonbukin there is now a confirmation dialog in the latest pre-release. Thanks for the suggestion here!

sestinj avatar Feb 29 '24 20:02 sestinj