continue icon indicating copy to clipboard operation
continue copied to clipboard

[CON-223] Cmd/Ctrl + Shift + Backspace doesn't stop streaming of diff

Open sestinj opened this issue 1 year ago • 1 comments

Before submitting your bug report

Relevant environment info

- OS:Mac
- Continue:0.9.91
- IDE:VS Code

Description

When the diff view is briefly going away it is because I am using the cmd+shift+backspace shortcut to cancel the generation, but after a second it comes back because streaming was not successfully cancelled.

https://github.com/continuedev/continue/assets/33237525/8fd80572-8fe9-4330-a563-2d7d59239d94

This is the function that gets called and is responsible for cancelling, so this is the starting point to debug.

To reproduce

  1. Highlight code
  2. Type '/edit fix this' or something similar
  3. when it starts generating, press cmd/ctrl+shift+backspace
  4. it will briefly go away but streaming continues and the diff view will return

Log output

No response

CON-223

sestinj avatar Mar 22 '24 01:03 sestinj

Continuing discussion from Discord: I was concerned that _streamSlashCommand wasn't behaving correctly because the generating function ideStreamRequest wasn't yielding anything.
After looking into it further, this seems to be the intention - ideStreamRequest and up is intended for streaming into the chat, not the diff. This is so parameters like 'recap' can be set to stream into the chat, without disrupting the diff.

justinmilner1 avatar Mar 31 '24 19:03 justinmilner1