storage icon indicating copy to clipboard operation
storage copied to clipboard

overlay: refactor getStagingDir helper

Open giuseppe opened this issue 1 year ago • 3 comments

simplify the implementation of getStagingDir() to just create a new staging directory and drop the check whether the correct staging base directory as anyway the rename operation would fail later.

Closes: https://github.com/containers/storage/issues/2092

giuseppe avatar Sep 24 '24 11:09 giuseppe

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: giuseppe

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Sep 24 '24 11:09 openshift-ci[bot]

@rhatdan thanks for the review. Addressed the comments

giuseppe avatar Sep 24 '24 14:09 giuseppe

LGTM

rhatdan avatar Sep 24 '24 20:09 rhatdan