storage icon indicating copy to clipboard operation
storage copied to clipboard

Assorted nits reported by revive linter

Open kolyshkin opened this issue 1 year ago • 3 comments

See individual commits for details.

kolyshkin avatar Sep 19 '24 23:09 kolyshkin

/approve LGTM

rhatdan avatar Sep 20 '24 22:09 rhatdan

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kolyshkin, rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Sep 20 '24 22:09 openshift-ci[bot]

Should this be enabling the linter in .golangci.yml, too?

nalind avatar Sep 23 '24 18:09 nalind

Should this be enabling the linter in .golangci.yml, too?

This linter is sort of too opinionated, and thus it's best to run it manually and only fix those warnings that make sense.

We can, of course, annotate all the warnings that we don't want to fix, and then enable the linter, but I'm not sure it makes sense.

kolyshkin avatar Sep 26 '24 08:09 kolyshkin

/lgtm

rhatdan avatar Sep 26 '24 18:09 rhatdan