storage
storage copied to clipboard
Assorted nits reported by revive linter
See individual commits for details.
/approve LGTM
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: kolyshkin, rhatdan
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [rhatdan]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
Should this be enabling the linter in .golangci.yml, too?
Should this be enabling the linter in
.golangci.yml, too?
This linter is sort of too opinionated, and thus it's best to run it manually and only fix those warnings that make sense.
We can, of course, annotate all the warnings that we don't want to fix, and then enable the linter, but I'm not sure it makes sense.
/lgtm