storage icon indicating copy to clipboard operation
storage copied to clipboard

Returns more than one additional image store

Open l0rd opened this issue 1 year ago • 2 comments

Closes #2094

l0rd avatar Sep 17 '24 15:09 l0rd

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: l0rd Once this PR has been reviewed and has the lgtm label, please assign edsantiago for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Sep 17 '24 15:09 openshift-ci[bot]

On the commit message: this repository like many others in this organization uses "Linux kernel style" commit messages, see the git log - this blog is one I reference often.

In this case I'd say something like:

List all image stores in serialized state

The config format and internals support multiple stores, but the serialized state only returns one. Add a new field which lists all so that external callers can see all of them.

?

cgwalters avatar Sep 17 '24 15:09 cgwalters

@l0rd still working on this one?

rhatdan avatar Nov 17 '24 11:11 rhatdan

@rhatdan yes. I mean I should resume working on this next week.

l0rd avatar Nov 17 '24 11:11 l0rd

When I first looked at https://github.com/containers/storage/issues/2094, I thought we had to address something in containers/storage. After looking at it again, I see that the problem is in container/podman, and there is nothing to fix here. I am closing this PR in favor of https://github.com/containers/podman/pull/24731

l0rd avatar Dec 02 '24 12:12 l0rd