storage icon indicating copy to clipboard operation
storage copied to clipboard

overlay: Extend documentation comment for layout

Open cgwalters opened this issue 1 year ago • 7 comments

Let's expand the existing doc comment, as it's really useful to understand the implementation in order to debug or improve things.

We also clearly say first that these are implementation details.

Signed-off-by: Colin Walters [email protected]

cgwalters avatar May 30 '24 18:05 cgwalters

BTW, feel free to (please do) just force push updates to this PR to add/fix things.

cgwalters avatar May 30 '24 18:05 cgwalters

@giuseppe PTAL

rhatdan avatar Jun 05 '24 14:06 rhatdan

/approve

rhatdan avatar Jun 05 '24 14:06 rhatdan

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cgwalters, rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Jun 05 '24 14:06 openshift-ci[bot]

LGTM

rhatdan avatar Jun 05 '24 19:06 rhatdan

@giuseppe @saschagrunert @mtrmac PTAL

rhatdan avatar Jun 20 '24 15:06 rhatdan

This one isn't urgent, I think we can just leave it as draft and I may circle back to it later. No need for others to dive in for review now, we have more important things.

cgwalters avatar Jun 20 '24 15:06 cgwalters

Hi, and thank you for your contribution!

We’ve recently migrated this repository into a new monorepo: containers/container-libs along with other repositories

As part of this migration, this repository is no longer accepting new Pull-Requests and therefore this Pull-Request is being closed.

Thank you very much for your contribution. We would appreciate your continued help in migrating this PR to the new container-libs repository. Please let us know if you are facing any issues.

You can read more about the migration and the reasoning behind it in our blog post: Upcoming migration of three containers repositories to monorepo.

Thanks again for your work and for supporting the containers ecosystem!

jankaluza avatar Aug 26 '25 14:08 jankaluza