skopeo icon indicating copy to clipboard operation
skopeo copied to clipboard

Published 20 hours ago • verified publisher icon containers

UNTESTED DO NOT MERGE: Update for golang-fips API changes

Open mtrmac opened this issue 1 year ago • 3 comments
trafficstars

Trying to see what a fix for the Packit-reported failures (as in https://github.com/containers/skopeo/pull/2297#issuecomment-2059524991 ) would look like.

@lsm5 does this build on all distributions we care about for the main branch of our products?

This passes libtrust tests on macOS, I need to also test this with the OpenSSl backend.

mtrmac avatar Apr 18 '24 16:04 mtrmac

Ephemeral COPR build failed. @containers/packit-build please check.

packit-as-a-service[bot] avatar Apr 18 '24 16:04 packit-as-a-service[bot]

From a quick analysis, the ecdsa.HashSign function referred to in https://github.com/containers/skopeo/pull/2297#issuecomment-2059577517 seems not to be public.

For reference, a (private) conversation motivating FIPS variant: https://bugzilla.redhat.com/show_bug.cgi?id=1740920 .

mtrmac avatar Apr 18 '24 17:04 mtrmac

sorry about the delay. my github notifications were messed up. I'll look into this today.

lsm5 avatar Apr 22 '24 13:04 lsm5

Follow https://github.com/containers/libtrust/pull/8 for current progress on these build failures.

mtrmac avatar May 09 '24 19:05 mtrmac

This was fixed in golang-fips, culminating in https://github.com/containers/libtrust/pull/8 .

mtrmac avatar Jun 06 '24 14:06 mtrmac